rasterstate/fj
rasterstate/fj
Watch
8
0
Fork
You've already forked fj
 0
Code Issues 23 Pull requests Releases 7 Activity Actions

Parse quoted arguments in alias expansions #90

Merged
stephen merged 1 commit from fix/alias-quoted-args into main 2026-06-08 12:14:30 +00:00
Conversation 0 Commits 1 Files changed 3 +41 -3
stephen commented 2026-06-08 05:17:11 +00:00
Owner
Copy link

Alias expansions were tokenized with `split_whitespace`, so a quoted argument was torn apart. After `fj alias set bug 'issue create --label "needs triage"'`, running `fj bug` handed clap the tokens `--label`, `"needs`, `triage"`, so the label became `"needs` instead of `needs triage`. `gh` parses alias expansions shell-style; this brings `fj` in line.

Tokenize the expansion with `shlex` (already present in the dependency tree at 1.3.0, the advisory-fixed release; only `split` is used, never the flagged `quote`). Malformed quoting falls back to whitespace splitting so a broken alias degrades to the old behaviour rather than vanishing. Tests cover quoted, plain, and malformed expansions.

Alias expansions were tokenized with \`split_whitespace\`, so a quoted argument was torn apart. After \`fj alias set bug 'issue create --label "needs triage"'\`, running \`fj bug\` handed clap the tokens \`--label\`, \`"needs\`, \`triage"\`, so the label became \`"needs\` instead of \`needs triage\`. \`gh\` parses alias expansions shell-style; this brings \`fj\` in line. Tokenize the expansion with \`shlex\` (already present in the dependency tree at 1.3.0, the advisory-fixed release; only \`split\` is used, never the flagged \`quote\`). Malformed quoting falls back to whitespace splitting so a broken alias degrades to the old behaviour rather than vanishing. Tests cover quoted, plain, and malformed expansions.
Parse quoted arguments in alias expansions
All checks were successful
ci / check (pull_request) Successful in 10m10s
Details
ci / live-e2e (pull_request) Successful in 1m44s
Details
ci / coverage (pull_request) Successful in 2m7s
Details
9bdf99d281 
Alias expansions were tokenized with split_whitespace, so a quoted argument
was torn apart: `fj alias set bug 'issue create --label "needs triage"'` then
`fj bug` passed clap the three tokens --label, "needs, triage", giving a label
of '"needs' rather than 'needs triage'. gh parses aliases shell-style; fj now
does too.

Tokenize the expansion with shlex (already in the dependency tree, 1.3.0, the
advisory-fixed release; only split is used, not the flagged quote). Malformed
quoting falls back to whitespace splitting so a broken alias degrades rather
than disappears. Adds tests for quoted, plain, and malformed expansions.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backlog
Accepted but not scheduled

  
blocked
Blocked or stalled waiting on external progress

  
converted
Converted into tracked work

  
forseti:changes-requested
Forseti review found unaddressed findings; cleared on a clean re-review at the current head.

  
opportunity
Potential product or business opportunity

  
p1
Priority 1

  
p2
Priority 2

  
p3
Priority 3

  
parked
Paused intentionally until later

No labels
backlog
blocked
converted
forseti:changes-requested
opportunity
p1
p2
p3
parked
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rasterstate/fj!90
No description provided.