ci(forseti): enable formal blocking review (Phase 1, visibility) #221

Merged

stephen merged 1 commit from chore/forseti-formal-review into main

2026-07-21 06:11:12 +00:00

stephen commented

2026-07-21 03:41:56 +00:00

Owner

Enables Forseti's formal pull review on fj (rasterstate/forseti #89, PR #90).

A blocking P0/P1 will show as a red REQUEST_CHANGES state in the PR list and clear to APPROVE on a clean re-review, instead of reviews: NONE. Bumps the token to pull-requests: write (needed to submit a review) and sets FORSETI_FORMAL_REVIEW=1.

fj main has block_on_rejected_reviews: false, so this is visible-but-non-blocking (Phase 1). The merge gate is a separate later step (FORSETI_GATE + the already-required * status context).

Sequencing: merge only after the forseti :stable image includes #90. An older image ignores the unknown env, so an early merge is harmless but does nothing until the image updates.

Enables Forseti's formal pull review on fj (rasterstate/forseti #89, PR #90). A blocking P0/P1 will show as a red `REQUEST_CHANGES` state in the PR list and clear to `APPROVE` on a clean re-review, instead of `reviews: NONE`. Bumps the token to `pull-requests: write` (needed to submit a review) and sets `FORSETI_FORMAL_REVIEW=1`. fj main has `block_on_rejected_reviews: false`, so this is **visible-but-non-blocking** (Phase 1). The merge gate is a separate later step (`FORSETI_GATE` + the already-required `*` status context). **Sequencing:** merge only after the forseti `:stable` image includes #90. An older image ignores the unknown env, so an early merge is harmless but does nothing until the image updates.

stephen added 1 commit

2026-07-21 03:41:56 +00:00

ci(forseti): enable formal blocking review (visibility, Phase 1)

Forseti review / forseti review (advisory) (pull_request_target) Successful in 22s

Details

ci / check (pull_request) Successful in 10m17s

Details

ci / live-e2e (pull_request) Successful in 1m54s

Details

ci / coverage (pull_request) Successful in 1m58s

Details

0488fb926d

Turn on Forseti's formal pull review (rasterstate/forseti #89) so a
blocking P0/P1 shows as a red 'changes requested' state in the PR list
and clears to APPROVE on a clean re-review, instead of reviews: NONE.

Bumps the token to pull-requests: write so the reviewer can submit a
review, and sets FORSETI_FORMAL_REVIEW=1. fj main does not block on
rejected reviews, so this is visible-but-non-blocking; the merge gate
stays a separate later step (FORSETI_GATE + the required status check).

Requires the forseti :stable image to include #89 before it takes
effect; an older image ignores the unknown env.

forgejo-actions commented

2026-07-21 03:42:17 +00:00

Forseti review

No blocking findings from the lead reviewer.

No inline findings.

PR: rasterstate/fj#221
Head SHA: 0488fb926d37
Review job: sha256:39a02f74c034322f13a6e48ff49d11f47705e2e6a7fd60f5701ac3f9c06d106c
Provider pair: openai:gpt-5.5+anthropic:claude-haiku-4-5-20251001
Blocking findings: 0
Inline findings: 0
Token source: GITHUB_TOKEN
Runner: f7c6961115b5
Run: https://rasterhub.com/rasterstate/fj/actions/runs/370

## Forseti review No blocking findings from the lead reviewer. _No inline findings._ - PR: `rasterstate/fj#221` - Head SHA: `0488fb926d37` - Review job: `sha256:39a02f74c034322f13a6e48ff49d11f47705e2e6a7fd60f5701ac3f9c06d106c` - Provider pair: `openai:gpt-5.5+anthropic:claude-haiku-4-5-20251001` - Blocking findings: `0` - Inline findings: `0` - Token source: `GITHUB_TOKEN` - Runner: `f7c6961115b5` - Run: https://rasterhub.com/rasterstate/fj/actions/runs/370

stephen merged commit 1251c71b59 into main

2026-07-21 06:11:12 +00:00

stephen referenced this pull request from a commit

2026-07-21 06:11:13 +00:00

ci(forseti): enable formal blocking review (Phase 1, visibility) (#221)