Fail benchmarks on cache action errors #2

Merged

stephen merged 1 commit from fix-bench-cache-failures into main

2026-06-08 05:12:47 +00:00

stephen commented

2026-06-08 05:02:57 +00:00

Owner

This makes the Rust, Node, and Go benchmark helpers fail the script when the cache action exits nonzero, while still printing the captured cache-action log for diagnosis.

Tests run:

bash -n benchmarks/scripts/bench-rust.sh benchmarks/scripts/bench-node.sh benchmarks/scripts/bench-go.sh

The benchmark scripts were ignoring cache-action failures in their restore and save helpers. A broken restore or save could still produce benchmark rows, which can make a warm run look valid when the cache path failed. This makes the Rust, Node, and Go benchmark helpers fail the script when the cache action exits nonzero, while still printing the captured cache-action log for diagnosis. Tests run: - bash -n benchmarks/scripts/bench-rust.sh benchmarks/scripts/bench-node.sh benchmarks/scripts/bench-go.sh

stephen added 1 commit

2026-06-08 05:02:57 +00:00

Fail benchmarks on cache action errors 895d4f2476

stephen merged commit 02ac0657b2 into main

2026-06-08 05:12:47 +00:00

stephen referenced this pull request from a commit

2026-06-08 05:12:48 +00:00

Fail benchmarks on cache action errors (#2)