auth: fall back to file token store on keychain errors #155

Merged
stephen merged 1 commit from fix/147b-keychain-noentry-fallback into main 2026-06-11 04:29:25 +00:00
Owner

Follow-up to fj#147.

Changes:

  • Fall back to the 0600 file token store on any keychain error while opening an entry or writing a password.
  • Keep load precedence as env > keychain > file, with NoEntry on keychain entry open covered by file fallback.
  • Add NoEntry tests for store entry-open fallback, store set_password fallback, and load fallback.

Local gates:

  • cargo fmt --check
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test --all

mandatory-review: AUTH/SECRETS cross-family review required.

Follow-up to fj#147. Changes: - Fall back to the 0600 file token store on any keychain error while opening an entry or writing a password. - Keep load precedence as env > keychain > file, with NoEntry on keychain entry open covered by file fallback. - Add NoEntry tests for store entry-open fallback, store set_password fallback, and load fallback. Local gates: - cargo fmt --check - cargo clippy --all-targets --all-features -- -D warnings - cargo test --all mandatory-review: AUTH/SECRETS cross-family review required.
auth: fall back to file store on keychain errors
All checks were successful
ci / check (pull_request) Successful in 9m57s
ci / live-e2e (pull_request) Successful in 1m48s
ci / coverage (pull_request) Successful in 2m6s
ebe9da2d4b
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
rasterstate/fj!155
No description provided.